Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: set default value when saving widget instance #22567

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Search: set default value when saving widget instance #22567

merged 1 commit into from
Feb 1, 2022

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jan 31, 2022

Changes proposed in this Pull Request:

This should avoid PHP warnings such as this one:

PHP Warning:  Undefined array key "sort" in /wp-content/plugins/jetpack-dev/modules/widgets/search.php on line 663

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Set up a new site, using a non-block theme like Twenty Twenty, buy a Jetpack Search plan.
  • Go to Appearance > Widgets
  • Ensure you can use the Jetpack Search widget
  • Ensure that there are no issues in your error log.

@jeherve
Search: set default value when saving widget instance
78f5b2f 
This should avoid PHP warnings such as this one:
```
PHP Warning:  Undefined array key "sort" in /wp-content/plugins/jetpack-dev/modules/widgets/search.php on line 663
```
@jeherve jeherve added this to the jetpack/10.7 milestone Jan 31, 2022
@jeherve jeherve added Instant Search [Feature] Search For all things related to Search [Pri] Normal [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Bug When a feature is broken and / or not performing as intended labels Jan 31, 2022
@jeherve jeherve self-assigned this Jan 31, 2022
@jeherve jeherve requested a review from a team January 31, 2022 14:39
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D74063-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Feature] Extra Sidebar Widgets labels Jan 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2022 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: February 1, 2022.
  • Scheduled code freeze: January 24, 2022.

@kangzj
Copy link
Contributor

kangzj commented Jan 31, 2022

Thanks @jeherve it works for me 👍

jsnmoon
jsnmoon approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@jsnmoon jsnmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable and tests well 👍

@jsnmoon jsnmoon added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jan 31, 2022
@jeherve jeherve merged commit e23c6e2 into master Feb 1, 2022
@jeherve jeherve deleted the fix/warning-search-instance branch February 1, 2022 09:25
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Great news! One last step: head over to your WordPress.com diff, D74063-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 1, 2022
@jeherve
Copy link
Member Author

jeherve commented Feb 1, 2022

r239314-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangzj kangzj kangzj approved these changes

@jsnmoon jsnmoon jsnmoon approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] Extra Sidebar Widgets [Feature] Search For all things related to Search [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
jetpack/10.7
Development

Successfully merging this pull request may close these issues.
4 participants
@jeherve @matticbot @kangzj @jsnmoon